[Mesa-dev] [PATCH 03/24] i965: Initialize all member variables of vec4_instruction on construction.

[Paul Berry]

On 15 September 2013 00:10, Francisco Jerez <currojerez at riseup.net> wrote:

> Ditto.  Otherwise some of its member variables are going to have
> uninitialized contents in cases where its memory is not allocated
> using rzalloc().
>

Nit pick: "ditto" implicitly refers to the commit message in patch 2.  I'd
prefer to see each commit message stand on its own, since commits often
wind up getting cherry-picked into alternate orders, or viewed in
isolation, so it won't always be obvious to the reader what "ditto" means.

With that fixed, the patch is:

Reviewed-by: Paul Berry <stereotype441 at gmail.com>


> ---
>  src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp
> b/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp
> index 304636a..9770f13 100644
> --- a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp
> @@ -38,7 +38,22 @@ vec4_instruction::vec4_instruction(vec4_visitor *v,
>     this->src[0] = src0;
>     this->src[1] = src1;
>     this->src[2] = src2;
> +   this->saturate = false;
> +   this->force_writemask_all = false;
> +   this->no_dd_clear = false;
> +   this->no_dd_check = false;
> +   this->conditional_mod = BRW_CONDITIONAL_NONE;
> +   this->sampler = 0;
> +   this->texture_offset = 0;
> +   this->target = 0;
> +   this->shadow_compare = false;
>     this->ir = v->base_ir;
> +   this->urb_write_flags = BRW_URB_WRITE_NO_FLAGS;
> +   this->header_present = false;
> +   this->mlen = 0;
> +   this->base_mrf = 0;
> +   this->offset = 0;
> +   this->ir = NULL;
>     this->annotation = v->current_annotation;
>  }
>
> --
> 1.8.3.4
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130917/117bdfd5/attachment.html>