[Mesa-dev] [PATCH 17/18] r600g,radeonsi: share r600_texture.c

[Michel Dänzer]

On Don, 2013-09-26 at 03:35 +0200, Marek Olšák wrote:
> From: Marek Olšák <marek.olsak at amd.com>
> 
> The function r600_choose_tiling is new and needs a review.
> 
> The only change in functionality is that it enables 2D tiling for compressed
> textures on SI. It was probably accidentally turned off.

[...]

>  19 files changed, 1134 insertions(+), 1991 deletions(-)

Now that's a nice diffstat. :)


> +static unsigned r600_choose_tiling(struct r600_common_screen *rscreen,
> +				   const struct pipe_resource *templ)
> +{

[...]

> +		/* Scanout buffers are linear on R600-Cayman. (XXX double-check) */
> +		if (rscreen->chip_class <= CAYMAN &&
> +		    (templ->bind & PIPE_BIND_SCANOUT))
> +			return RADEON_SURF_MODE_LINEAR_ALIGNED;

Pretty sure R600-Cayman hardware can scan out tiled buffers as well.


> +		/* Cursors are linear on SI. (XXX double-check for CIK) */
> +		if (rscreen->chip_class >= SI &&
> +		    (templ->bind & PIPE_BIND_CURSOR))
> +			return RADEON_SURF_MODE_LINEAR_ALIGNED;

Not sure about this, but I doubt tiling would make a significant
difference for cursors anyway.


The rest of the series looks good to me, though I haven't looked at the
larger patches in too much detail. Nice work!


-- 
Earthling Michel Dänzer            |                  http://www.amd.com
Libre software enthusiast          |                Mesa and X developer