[Mesa-dev] [PATCH 1/5] glsl_compiler: Use no_argument instead of 0 in getopt_long options
Ian Romanick
idr at freedesktop.org
Fri Sep 27 12:10:54 PDT 2013
I also forgot to mention... my next intended step is to have the
stand-alone compiler be installed as part of the regular Mesa install
process. The build system terrifies / annoys me enough that I'll have
to solicit some help doing that...
On 09/27/2013 11:58 AM, Ian Romanick wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
>
> The choices aren't just 0 and 1, so using the enum names is much more
> clear.
>
> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
> ---
> This goes on top of the series that I just sent. I sent them as
> separate series because they're logically separate. I don't think there
> will be many issues with the other, but there will likely be some
> disucssion about this one.
>
> Since I made this available as a branch, one ISV has already started
> experimenting with it.
>
> src/glsl/main.cpp | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/src/glsl/main.cpp b/src/glsl/main.cpp
> index 57bec44..bc15835 100644
> --- a/src/glsl/main.cpp
> +++ b/src/glsl/main.cpp
> @@ -110,11 +110,11 @@ int dump_lir = 0;
> int do_link = 0;
>
> const struct option compiler_opts[] = {
> - { "glsl-es", 0, &glsl_es, 1 },
> - { "dump-ast", 0, &dump_ast, 1 },
> - { "dump-hir", 0, &dump_hir, 1 },
> - { "dump-lir", 0, &dump_lir, 1 },
> - { "link", 0, &do_link, 1 },
> + { "glsl-es", no_argument, &glsl_es, 1 },
> + { "dump-ast", no_argument, &dump_ast, 1 },
> + { "dump-hir", no_argument, &dump_hir, 1 },
> + { "dump-lir", no_argument, &dump_lir, 1 },
> + { "link", no_argument, &do_link, 1 },
> { NULL, 0, NULL, 0 }
> };
>
>
More information about the mesa-dev
mailing list