[Mesa-dev] [PATCH 6/9] glsl: Validate that base types match for a number of binops.
Kenneth Graunke
kenneth at whitecape.org
Sun Apr 6 23:49:52 PDT 2014
The IR is not supposed to support implicit type conversions; we just
failed to validate it.
Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
---
src/glsl/ir_validate.cpp | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/glsl/ir_validate.cpp b/src/glsl/ir_validate.cpp
index 527acea..71defc8 100644
--- a/src/glsl/ir_validate.cpp
+++ b/src/glsl/ir_validate.cpp
@@ -381,6 +381,9 @@ ir_validate::visit_leave(ir_expression *ir)
case ir_binop_min:
case ir_binop_max:
case ir_binop_pow:
+ assert(ir->operands[0]->type->base_type ==
+ ir->operands[1]->type->base_type);
+
if (ir->operands[0]->type->is_scalar())
assert(ir->operands[1]->type == ir->type);
else if (ir->operands[1]->type->is_scalar())
--
1.9.0
More information about the mesa-dev
mailing list