[Mesa-dev] [PATCH 00/12] Again Klocwork patches

[Juha-Pekka Heikkilä]

On Mon, Apr 7, 2014 at 11:21 PM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> On 07/04/14 21:06, Juha-Pekka Heikkilä wrote:
>> Hmm... Wonder where my patches 9..12 vanished. They show in git
>> send-email as "Result: 250 ok:  Message ### accepted". If they don't
>> magically show up here I will resend entire set tomorrow from better
>> connection.
>>
> An innocent bystander type of questions:
>
> - Why do you resend the whole series every time, rather than re-sending only
> the updated patches ?

The set changes often quite much and due to nature of Klocwork touches
totally different areas in Mesa, bookkeeping I guess is not among my
best features -- patches in any case reflect the expected change I
think. As a side nuance I use gmail for sending patches, gmail strips
headers from emails causing I often don't find "Message-Id" field so
easy for old emails. If anyone know where to get full email headers
with gmail I will be happy to know :)

> - Noticed that you mention the changes between patch revisions only in some
> cases. Is that intentional ?

When the set has gone through bigger change its easier just to ditch
the history rather than to strip what's left and what's not. Last I
separated reviewed committable patches which Tapani committed to
master thus I left the history again out, ie. the amount of patches
maybe stay close to same as before but its just because I don't want
to over grow the set. In total through these Klocwork patches there
went fixes which so far allowed to close 200+ Klocwork reported issues
from Mesa.

>
> Just curious :)
>
> -Emil
>
>> /Juha-Pekka
>>
>> On Mon, Apr 7, 2014 at 10:48 PM, Juha-Pekka Heikkila
>> <juhapekka.heikkila at gmail.com> wrote:
>>> Set of patches which mostly were here earlier, hope I did not this time miss
>>> any comments. #12 is new to the set. These pass Piglit quick tests with no
>>> regression on my Ivybridge.
>>>
>>> /Juha-Pekka
>>>
>>> Ian Romanick (1):
>>>   mesa: Add _mesa_error_no_memory for logging out-of-memory messages
>>>
>>> Juha-Pekka Heikkila (11):
>>>   mesa: add missing null checks in _tnl_register_fastpath()
>>>   mesa: add extra null checks in vbo_rebase_prims()
>>>   mesa: In emit_texenv() type mismatch was forced with typecast
>>>   mesa: Add missing null checks into prog_hash_table.c
>>>   glsl: add missing null check in tfeedback_decl::init()
>>>   mesa: add missing null check in _mesa_NewHashTable()
>>>   i965: check malloc return value in intel_resolve_map_set()
>>>   mesa: add null checks in symbol_table.c
>>>   glsl: Add null check in loop_analysis.cpp
>>>   glsl: check _mesa_hash_table_create return value in
>>>     link_uniform_blocks
>>>   i965/fs: Check variable_storage return value in fs_visitor::visit
>>>
>>>  src/glsl/Makefile.am                          | 13 ++++++++----
>>>  src/glsl/link_uniform_blocks.cpp              |  5 +++++
>>>  src/glsl/link_varyings.cpp                    |  5 +++++
>>>  src/glsl/loop_analysis.cpp                    |  6 ++++--
>>>  src/glsl/main.cpp                             |  6 ++++++
>>>  src/glsl/tests/common.c                       | 30 +++++++++++++++++++++++++++
>>>  src/mesa/drivers/dri/i965/brw_fs_visitor.cpp  |  6 ++++++
>>>  src/mesa/drivers/dri/i965/intel_resolve_map.c |  7 +++++++
>>>  src/mesa/main/errors.c                        |  6 ++++++
>>>  src/mesa/main/errors.h                        |  3 +++
>>>  src/mesa/main/ff_fragment_shader.cpp          | 17 ++++++++-------
>>>  src/mesa/main/hash.c                          | 10 +++++++++
>>>  src/mesa/program/prog_hash_table.c            |  8 +++++++
>>>  src/mesa/program/symbol_table.c               | 30 +++++++++++++++++++++++++++
>>>  src/mesa/tnl/t_vertex.c                       | 14 +++++++++++--
>>>  src/mesa/vbo/vbo_rebase.c                     | 19 +++++++++++++++++
>>>  16 files changed, 169 insertions(+), 16 deletions(-)
>>>  create mode 100644 src/glsl/tests/common.c
>>>
>>> --
>>> 1.8.1.2
>>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>>
>