[Mesa-dev] [PATCH 00/12] Again Klocwork patches

Emil Velikov emil.l.velikov at gmail.com
Mon Apr 7 14:33:03 PDT 2014


On 07/04/14 22:10, Juha-Pekka Heikkilä wrote:
> On Mon, Apr 7, 2014 at 11:21 PM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>> On 07/04/14 21:06, Juha-Pekka Heikkilä wrote:
>>> Hmm... Wonder where my patches 9..12 vanished. They show in git
>>> send-email as "Result: 250 ok:  Message ### accepted". If they don't
>>> magically show up here I will resend entire set tomorrow from better
>>> connection.
>>>
>> An innocent bystander type of questions:
>>
>> - Why do you resend the whole series every time, rather than re-sending only
>> the updated patches ?
> 
> The set changes often quite much and due to nature of Klocwork touches
> totally different areas in Mesa, bookkeeping I guess is not among my
> best features -- patches in any case reflect the expected change I
> think. As a side nuance I use gmail for sending patches, gmail strips
> headers from emails causing I often don't find "Message-Id" field so
> easy for old emails. If anyone know where to get full email headers
> with gmail I will be happy to know :)
> 
AFAICS you're using git send-email to send that patches, which preserves all
the header tags (including the message-id). Although I'm not sure if using
gmail's web UI won't mess things up.

>> - Noticed that you mention the changes between patch revisions only in some
>> cases. Is that intentional ?
> 
> When the set has gone through bigger change its easier just to ditch
> the history rather than to strip what's left and what's not. Last I
> separated reviewed committable patches which Tapani committed to
> master thus I left the history again out, ie. the amount of patches
> maybe stay close to same as before but its just because I don't want
> to over grow the set. In total through these Klocwork patches there
> went fixes which so far allowed to close 200+ Klocwork reported issues
> from Mesa.
> 
Only 200 issues, that's nothing :P

Thanks for the extensive reply.
-Emil


More information about the mesa-dev mailing list