[Mesa-dev] [PATCH 1/5] dri: Expand driParseDebugString return value to uint64_t.

[Kenneth Graunke]

On 04/11/2014 10:29 PM, Matt Turner wrote:
> Users will downcast if they don't have >32 debug flags.
> ---
>  src/mesa/drivers/dri/common/utils.c | 7 +++----
>  src/mesa/drivers/dri/common/utils.h | 4 ++--
>  2 files changed, 5 insertions(+), 6 deletions(-)
> 
> diff --git a/src/mesa/drivers/dri/common/utils.c b/src/mesa/drivers/dri/common/utils.c
> index 1f29e0b..eee77ec 100644
> --- a/src/mesa/drivers/dri/common/utils.c
> +++ b/src/mesa/drivers/dri/common/utils.c
> @@ -32,6 +32,7 @@
>  #include <string.h>
>  #include <stdlib.h>
>  #include <stdbool.h>
> +#include <stdint.h>
>  #include "main/macros.h"
>  #include "main/mtypes.h"
>  #include "main/cpuinfo.h"
> @@ -40,14 +41,12 @@
>  #include "dri_util.h"
>  
>  
> -unsigned
> +uint64_t
>  driParseDebugString( const char * debug, 
>  		     const struct dri_debug_control * control  )
>  {
> -   unsigned   flag;
> -
> +   uint64_t flag = 0;
>  
> -   flag = 0;
>     if ( debug != NULL ) {
>        while( control->string != NULL ) {
>  	 if ( !strcmp( debug, "all" ) ||
> diff --git a/src/mesa/drivers/dri/common/utils.h b/src/mesa/drivers/dri/common/utils.h
> index 0941434..3760c38 100644
> --- a/src/mesa/drivers/dri/common/utils.h
> +++ b/src/mesa/drivers/dri/common/utils.h
> @@ -34,10 +34,10 @@
>  
>  struct dri_debug_control {
>      const char * string;
> -    unsigned     flag;
> +    uint64_t     flag;
>  };
>  
> -extern unsigned driParseDebugString( const char * debug,
> +extern uint64_t driParseDebugString( const char * debug,
>      const struct dri_debug_control * control );
>  
>  extern unsigned driGetRendererString( char * buffer,
> 

Patches 1-2 are:
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140413/8124aeee/attachment.sig>