[Mesa-dev] [PATCH] i965: Don't force pre-Gen6 varying pull loads to use uncompressed SENDs.

Eric Anholt eric at anholt.net
Wed Apr 16 09:32:23 PDT 2014


Kenneth Graunke <kenneth at whitecape.org> writes:

> Prior to commit b207e88b25e526d0f1ada7b19605b880a27866dc (i965/fs:
> Support pull parameters in SIMD16 mode.), we only supported pull
> constants in SIMD8 mode.  SIMD8 shaders are always uncompressed, so
> forcing this SEND to be uncompressed should have had no effect.
>
> However, once we began supporting pull constants in SIMD16 mode, it
> began to matter: it really ought to be compressed in SIMD16 mode.
>
> Fixes Piglit's glsl-fs-normalmatrix, glsl-fs-uniform-array-2,
> glsl-fs-uniform-array-6, adn glsl-fs-uniform-array-7 on Ironlake,
> which regressed with the aforementioned commit.

Does it also get fixed with dst.type = BRW_REGISTER_TYPE_UW?  That's
what we do with texture loads and fb writes to get the right exec mask
on a send in simd16.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140416/2182c93d/attachment.sig>


More information about the mesa-dev mailing list