[Mesa-dev] [PATCH 1/2] i965/fs: Don't use brw_imm_* unnecessarily.

[Kenneth Graunke]

On 04/17/2014 04:04 PM, Matt Turner wrote:
> Using brw_imm_* creates a source with file=HW_REG, and the scheduler
> inserts barrier dependencies when it sees HW_REG. None of these are
> hardware-registers in the sense that they're special and scheduling
> shouldn't touch them. A few of the modified cases already have HW_REGs
> for other sources, so it won't allow extra flexibility in some cases.
> ---
>  src/mesa/drivers/dri/i965/brw_fs.cpp         | 4 ++--
>  src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 6 +++---
>  2 files changed, 5 insertions(+), 5 deletions(-)

Both patches are:
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

I do think we should mark the fs_reg(struct brw_reg) constructor
'explicit' to avoid this problem from creeping in again.  There are
other cases that don't consider HW_REG && fixed_hw_reg.file == IMM, so
we really want to avoid doing that and just use IMM properly.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140417/a557d5f9/attachment-0001.sig>