[Mesa-dev] [PATCH 04/12] mesa/format_info: Add support for the BPTC layout

Jason Ekstrand jason at jlekstrand.net
Wed Aug 6 09:57:06 PDT 2014


Sorry, said that just a little early.  Do we really want 4 bits for a
floating-point format?  How many bits does nvidia report?
--Jason


On Wed, Aug 6, 2014 at 9:55 AM, Jason Ekstrand <jason at jlekstrand.net> wrote:

> This looks fine to me.
> Reviewed-by: Jason Ekstrand <jason.ekstrand at intel.com>
>
>
> On Wed, Aug 6, 2014 at 9:27 AM, Neil Roberts <neil at linux.intel.com> wrote:
>
>> Adds the ‘bptc’ layout to get_channel_bits. The channel bits for BPTC
>> depend
>> on the mode but as it only has to be an approximation we can set it to 4
>> like
>> for S3TC.
>> ---
>>  src/mesa/main/format_info.py | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/mesa/main/format_info.py b/src/mesa/main/format_info.py
>> index a0eecd3..fc40dc4 100644
>> --- a/src/mesa/main/format_info.py
>> +++ b/src/mesa/main/format_info.py
>> @@ -110,7 +110,7 @@ def get_channel_bits(fmat, chan_name):
>>     if fmat.is_compressed():
>>        # These values are pretty-much bogus, but OpenGL requires that we
>>        # return an "approximate" number of bits.
>> -      if fmat.layout == 's3tc':
>> +      if fmat.layout in ('s3tc', 'bptc'):
>>           return 4 if fmat.has_channel(chan_name) else 0
>>        elif fmat.layout == 'fxt1':
>>           if chan_name in 'rgb':
>> --
>> 1.9.3
>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140806/87980add/attachment.html>


More information about the mesa-dev mailing list