[Mesa-dev] [PATCH 6/6] rbug: only add textures to the list

[Roland Scheidegger]

Am 18.08.2014 23:24, schrieb Marek Olšák:
> From: Marek Olšák <marek.olsak at amd.com>
> 
> rbug-gui cannot display buffers, so it's pointless to add them.
> ---
>  src/gallium/drivers/rbug/rbug_objects.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/src/gallium/drivers/rbug/rbug_objects.c b/src/gallium/drivers/rbug/rbug_objects.c
> index 2d80164..db18f2e 100644
> --- a/src/gallium/drivers/rbug/rbug_objects.c
> +++ b/src/gallium/drivers/rbug/rbug_objects.c
> @@ -58,7 +58,8 @@ rbug_resource_create(struct rbug_screen *rb_screen,
>     rb_resource->base.screen = &rb_screen->base;
>     rb_resource->resource = resource;
>  
> -   rbug_screen_add_to_list(rb_screen, resources, rb_resource);
> +   if (resource->target != PIPE_BUFFER)
> +      rbug_screen_add_to_list(rb_screen, resources, rb_resource);
>  
>     return &rb_resource->base;
>  
> @@ -71,7 +72,9 @@ void
>  rbug_resource_destroy(struct rbug_resource *rb_resource)
>  {
>     struct rbug_screen *rb_screen = rbug_screen(rb_resource->base.screen);
> -   rbug_screen_remove_from_list(rb_screen, resources, rb_resource);
> +
> +   if (rb_resource->base.target != PIPE_BUFFER)
> +      rbug_screen_remove_from_list(rb_screen, resources, rb_resource);
>  
>     pipe_resource_reference(&rb_resource->resource, NULL);
>     FREE(rb_resource);
> 

I wonder if there would be some value in trying to make them
displayable? I guess though it would be pretty difficult without any
means to figure out what kind of data it is.

Reviewed-by: Roland Scheidegger <sroland at vmware.com>