[Mesa-dev] [PATCH] swrast: Use integer value 1 for true

Tapani tapani.palli at intel.com
Tue Aug 26 00:41:21 PDT 2014


On 08/25/2014 07:19 PM, Eric Anholt wrote:
> Tapani Pälli <tapani.palli at intel.com> writes:
>
>> commit 4e64cfbb4 changed how gl_constant_value bool gets interpreted
>> with drivers, for swrast driver true should be 1.
>>
>> Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=82978
> Everywhere else in swrast, true is 1.0f.  Pretty sure you want fui(1.0)
> here.

OK, my goal was to restore old behavior which seems that it had either 
value 1 or 0, set by glUniform functions or a uniform initializer. Maybe 
conversion to float is happening when reading the values from the 
uniform storage?

// Tapani



More information about the mesa-dev mailing list