[Mesa-dev] [PATCH 4/5] mesa: some improvements for print_list()

[Brian Paul]

On 12/01/2014 03:59 PM, Kenneth Graunke wrote:
> On Monday, December 01, 2014 01:44:22 PM Brian Paul wrote:
>> Add a filename parameter to print_list() so that a display list can
>> be printed to a file.
>> ---
>>   src/mesa/main/dlist.c       | 150 ++++++++++++++++++++++++--------------------
>>   src/mesa/main/dlist.h       |   2 +-
>>   src/mesa/vbo/vbo_save_api.c |   8 +--
>>   3 files changed, 87 insertions(+), 73 deletions(-)
>>
>> diff --git a/src/mesa/main/dlist.c b/src/mesa/main/dlist.c
>> index 4b7b060..a087f79 100644
>> --- a/src/mesa/main/dlist.c
>> +++ b/src/mesa/main/dlist.c


>> @@ -9964,6 +9975,9 @@ print_list(struct gl_context *ctx, GLuint list)
>>            }
>>         }
>>      }
>> +
>> +   fflush(f);
>> +   fclose(f);
>
> It looks like this would close stdout.  Presumably you want:
>
>     if (fname)
>        fclose(f);

Yes, thanks!

-Brian


> With that fixed, the series is:
> Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
>