[Mesa-dev] [PATCH] i965/brw_reg: struct constructor now needs explicit negate and abs values.

[Matt Turner]

On Fri, Dec 12, 2014 at 8:19 AM, Andres Gomez <agomez at igalia.com> wrote:
> We were asuming, when constructing a new brw_reg struct, that the

Typo: assuming

> negate and abs register modifiers would not be present by default in
> the new register.
>
> Now, we force explicitly setting these values when constructing a new
> register.
>
> This will avoid problems like forgetting to properly set them when we
> are using a previous register to generate this new register, as it was
> happening in the dFdx and dFdy generation functions.
>
> Fixes piglit test shaders/glsl-deriv-varyings
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=82991

Wow. Nice work tracking this down.

Reviewed-by: Matt Turner <mattst88 at gmail.com>
Cc: "10.4 10.3" <mesa-stable at lists.freedesktop.org>