[Mesa-dev] [PATCH 2/8] i965: Micro-optimize brw_get_index_type

[Matt Turner]

On Sun, Dec 21, 2014 at 11:40 AM, Ian Romanick <idr at freedesktop.org> wrote:
>>> diff --git a/src/mesa/drivers/dri/i965/brw_draw_upload.c b/src/mesa/drivers/dri/i965/brw_draw_upload.c
>>> index 6e0cf3e..e46c54b 100644
>>> --- a/src/mesa/drivers/dri/i965/brw_draw_upload.c
>>> +++ b/src/mesa/drivers/dri/i965/brw_draw_upload.c
>>> @@ -344,17 +344,6 @@ brw_get_vertex_surface_type(struct brw_context *brw,
>>>     }
>>>  }
>>>
>>> -unsigned
>>> -brw_get_index_type(GLenum type)
>>> -{
>>> -   switch (type) {
>>> -   case GL_UNSIGNED_BYTE:  return BRW_INDEX_BYTE;
>>> -   case GL_UNSIGNED_SHORT: return BRW_INDEX_WORD;
>>> -   case GL_UNSIGNED_INT:   return BRW_INDEX_DWORD;
>>
>> The BRW_INDEX_* defines are now unused. I'd remove them.
>
> Separate patch or with this patch?

No preference really.