[Mesa-dev] [PATCH] mesa: change GL_ALL_ATTRIB_BITS to 0xFFFFFFFF

Brian Paul brianp at vmware.com
Sun Feb 2 15:00:49 CET 2014


This has been wrong for many years.  It was originally 0x000FFFFF and long
ago there was discussion about whether GL_ALL_ATTRIB_BITS should include
the then-new GL_MULTISAMPLE_BIT bit.  Eventually the ARB decided that
glPushAttrib(GL_ALL_ATTRIB_BITS) should save all current and future
attribute groups (hence ~0).  Unfortunately, Mesa's gl.h was never updated.

This was just recently spotted by Eric Anholt and reported as a bug to the
ARB.  Ian, Jon Leech and I discussed it at the ARB meeting and decided to
change Mesa's value to reflect the ARB's decision.
---
 include/GL/gl.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/GL/gl.h b/include/GL/gl.h
index 48343f6..4e2932d 100644
--- a/include/GL/gl.h
+++ b/include/GL/gl.h
@@ -694,7 +694,7 @@ typedef double		GLclampd;	/* double precision float in [0,1] */
 #define GL_LIST_BIT				0x00020000
 #define GL_TEXTURE_BIT				0x00040000
 #define GL_SCISSOR_BIT				0x00080000
-#define GL_ALL_ATTRIB_BITS			0x000FFFFF
+#define GL_ALL_ATTRIB_BITS			0xFFFFFFFF
 
 
 /* OpenGL 1.1 */
-- 
1.7.10.4



More information about the mesa-dev mailing list