[Mesa-dev] [PATCH] mesa: change GL_ALL_ATTRIB_BITS to 0xFFFFFFFF

[Eric Anholt]

Brian Paul <brianp at vmware.com> writes:

> This has been wrong for many years.  It was originally 0x000FFFFF and long
> ago there was discussion about whether GL_ALL_ATTRIB_BITS should include
> the then-new GL_MULTISAMPLE_BIT bit.  Eventually the ARB decided that
> glPushAttrib(GL_ALL_ATTRIB_BITS) should save all current and future
> attribute groups (hence ~0).  Unfortunately, Mesa's gl.h was never updated.
>
> This was just recently spotted by Eric Anholt and reported as a bug to the
> ARB.  Ian, Jon Leech and I discussed it at the ARB meeting and decided to
> change Mesa's value to reflect the ARB's decision.

Neither was Apple's gl.h or Windows's.  Changing it this late in GL's
existence just seems ridiculous.  But khronos seems really intent on
that, so oh well.

Acked-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140202/d1e430f9/attachment.pgp>