[Mesa-dev] [PATCH] glsl: Initialize ubo_binding_mask flags to zero.

[Kenneth Graunke]

On 02/03/2014 11:53 AM, Matt Turner wrote:
> Missed in commit e63bb298. Caused sporadic test failures, like
> incorrect-in-layout-qualifier-repeated-prim.geom.
> 
> Cc: "10.0" <mesa-stable at lists.freedesktop.org>
> ---
>  src/glsl/ast_type.cpp | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/glsl/ast_type.cpp b/src/glsl/ast_type.cpp
> index 637da0d..5069326 100644
> --- a/src/glsl/ast_type.cpp
> +++ b/src/glsl/ast_type.cpp
> @@ -118,6 +118,7 @@ ast_type_qualifier::merge_qualifier(YYLTYPE *loc,
>     ubo_layout_mask.flags.q.shared = 1;
>  
>     ast_type_qualifier ubo_binding_mask;
> +   ubo_binding_mask.flags.i = 0;
>     ubo_binding_mask.flags.q.explicit_binding = 1;
>     ubo_binding_mask.flags.q.explicit_offset = 1;
>  
> 

LGTM

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140203/0c749472/attachment-0001.pgp>