[Mesa-dev] [PATCH] glsl: Initialize ubo_binding_mask flags to zero.

Jordan Justen jljusten at gmail.com
Tue Feb 4 09:07:13 CET 2014


Sigh ... So that explains the "regression" I was seeing with my
instanced GS branch.

Reviewed-by: Jordan Justen <jordan.l.justen at intel.com>

On Mon, Feb 3, 2014 at 11:53 AM, Matt Turner <mattst88 at gmail.com> wrote:
> Missed in commit e63bb298. Caused sporadic test failures, like
> incorrect-in-layout-qualifier-repeated-prim.geom.
>
> Cc: "10.0" <mesa-stable at lists.freedesktop.org>
> ---
>  src/glsl/ast_type.cpp | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/src/glsl/ast_type.cpp b/src/glsl/ast_type.cpp
> index 637da0d..5069326 100644
> --- a/src/glsl/ast_type.cpp
> +++ b/src/glsl/ast_type.cpp
> @@ -118,6 +118,7 @@ ast_type_qualifier::merge_qualifier(YYLTYPE *loc,
>     ubo_layout_mask.flags.q.shared = 1;
>
>     ast_type_qualifier ubo_binding_mask;
> +   ubo_binding_mask.flags.i = 0;
>     ubo_binding_mask.flags.q.explicit_binding = 1;
>     ubo_binding_mask.flags.q.explicit_offset = 1;
>
> --
> 1.8.3.2
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list