[Mesa-dev] [PATCH 11/30] mesa: Change redundant code into loops in shaderapi.c.

[Paul Berry]

On 9 January 2014 20:03, Chris Forbes <chrisf at ijw.co.nz> wrote:

> This is a slightly odd construction (although copied from the existing
> code):
>
> >  +  if ((shProg == NULL) || (shProg->_LinkedShaders[stage] == NULL))
> >  +    shProg = NULL;
>

You're right.  This would be much better as:

   if ((shProg != NULL) && (shProg->_LinkedShaders[stage] == NULL))
      shProg = NULL;

I'll update it in a follow-up patch.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140110/8cbfbb91/attachment.html>