[Mesa-dev] [PATCH V2 1/8] mesa: Add ARB_arrays_of_arrays

[Paul Berry]

On 21 January 2014 04:19, Timothy Arceri <t_arceri at yahoo.com.au> wrote:

> Signed-off-by: Timothy Arceri <t_arceri at yahoo.com.au>
> ---
>  src/mesa/main/extensions.c | 1 +
>  src/mesa/main/mtypes.h     | 1 +
>  2 files changed, 2 insertions(+)
>

Since this is a GLSL extension, you also need to update
glcpp_parser_create() (in glcpp-parse.y) to call add_builtin_define(parser,
"GL_ARB_arrays_of_arrays") if extensions->ARB_arrays_of_arrays is set.

With that fixed, this patch is:

Reviewed-by: Paul Berry <stereotype441 at gmail.com>

Personally I would also add the extension to the
_mesa_glsl_supported_extensions[] table in this patch, as well as add the
bools ARB_arrays_of_arrays_enable and ARB_arrays_of_arrays_warn to
_mesa_glsl_parse_state.  I see you've done that as part of patch 3/8
instead.  I suppose that's a matter of personal preference though.


>
> diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c
> index 2e0ccc3..95eb7ca 100644
> --- a/src/mesa/main/extensions.c
> +++ b/src/mesa/main/extensions.c
> @@ -80,6 +80,7 @@ static const struct extension extension_table[] = {
>     /* ARB Extensions */
>     { "GL_ARB_ES2_compatibility",
> o(ARB_ES2_compatibility),                   GL,             2009 },
>     { "GL_ARB_ES3_compatibility",
> o(ARB_ES3_compatibility),                   GL,             2012 },
> +   { "GL_ARB_arrays_of_arrays",
>  o(ARB_arrays_of_arrays),                    GL,             2012 },
>     { "GL_ARB_base_instance",                       o(ARB_base_instance),
>                       GL,             2011 },
>     { "GL_ARB_blend_func_extended",
> o(ARB_blend_func_extended),                 GL,             2009 },
>     { "GL_ARB_clear_buffer_object",                 o(dummy_true),
>                      GL,             2012 },
> diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h
> index 33df682..eef67a8 100644
> --- a/src/mesa/main/mtypes.h
> +++ b/src/mesa/main/mtypes.h
> @@ -3366,6 +3366,7 @@ struct gl_extensions
>     GLboolean ANGLE_texture_compression_dxt;
>     GLboolean ARB_ES2_compatibility;
>     GLboolean ARB_ES3_compatibility;
> +   GLboolean ARB_arrays_of_arrays;
>     GLboolean ARB_base_instance;
>     GLboolean ARB_blend_func_extended;
>     GLboolean ARB_color_buffer_float;
> --
> 1.8.3.1
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140121/b87678c4/attachment-0001.html>