[Mesa-dev] [PATCH V3 7/8] glsl: remove remaining is_array variables

[Timothy Arceri]

> I'm guessing you missed this because you are building in release mode, so asserts didn't get compiled.  If that's the > case, I'd like to encourage you to do a debug build and double-check that piglit tests still pass.  You can do that by > adding the "--enable-debug" option when you run ./autogen.sh.


Yes I didnt have --enable-debug set thanks for the tip. I've sent an updated patch and also rerun my piglit tests which caused two asserts to fail. I've sent a follow up patch for one in the ir code although I dont full understand that bit of code yet so advice welcome on that one if its not right.
The other one is in the i965 backend brw_vec4_visitor.cpp:type_size() an interface in the case statement has assert(0) but I think this one can wait until the linking/backend support is done. 


> I'll try to push my patch "glsl: Simplify aggregate type inference to prepare for ARB_arrays_of_arrays." > within the next hour.  Do you have commit access to Mesa or would you like me to push the series for you?

I have commit access but feel free to push it for me if you like, I'll push it if you haven't already done so when I get home tonight (in around 8 hours).
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140122/647efba3/attachment.html>