[Mesa-dev] [PATCH 05/18] glapi: Add infrastructure for ARB_multi_bind

[Ian Romanick]

On 01/22/2014 09:00 AM, Brian Paul wrote:
> On 01/21/2014 03:35 PM, Fredrik Höglund wrote:
>> ---
>>   src/mapi/glapi/gen/ARB_multi_bind.xml   |   53
>> +++++++++++++++++++++++++++++++
>>   src/mapi/glapi/gen/Makefile.am          |    1 +
>>   src/mapi/glapi/gen/gl_API.xml           |    4 +++
>>   src/mesa/main/bufferobj.c               |   13 ++++++++
>>   src/mesa/main/bufferobj.h               |    7 ++++
>>   src/mesa/main/samplerobj.c              |    6 ++++
>>   src/mesa/main/samplerobj.h              |    2 ++
>>   src/mesa/main/shaderimage.c             |    5 +++
>>   src/mesa/main/shaderimage.h             |    3 ++
>>   src/mesa/main/tests/dispatch_sanity.cpp |    8 +++++
>>   src/mesa/main/texobj.c                  |    6 ++++
>>   src/mesa/main/texobj.h                  |    4 +++
>>   src/mesa/main/varray.c                  |    7 ++++
>>   src/mesa/main/varray.h                  |    4 +++
>>   14 files changed, 123 insertions(+)
>>   create mode 100644 src/mapi/glapi/gen/ARB_multi_bind.xml
>>
>> diff --git a/src/mapi/glapi/gen/ARB_multi_bind.xml
>> b/src/mapi/glapi/gen/ARB_multi_bind.xml
>> new file mode 100644
>> index 0000000..4a59d8c
>> --- /dev/null
>> +++ b/src/mapi/glapi/gen/ARB_multi_bind.xml
>> @@ -0,0 +1,53 @@
>> +<?xml version="1.0"?>
>> +<!DOCTYPE OpenGLAPI SYSTEM "gl_API.dtd">
>> +
>> +<!-- Note: no GLX protocol info yet. -->
>> +
>> +<OpenGLAPI>
>> +
>> +<category name="GL_ARB_multi_bind" number="147">
>> +
>> +    <function name="BindBuffersBase" offset="assign">
>> +        <param name="target" type="GLenum"/>
>> +        <param name="first" type="GLuint"/>
>> +        <param name="count" type="GLsizei"/>
>> +        <param name="buffers" type="const GLuint*"/>
> 
> I don't recall if the glapi python code parses these types, but it might
> be safer to put add space before '*' as we do elsewhere.  So:

I think it just takes the whole string.  This should be safe as-is, but
being consistent is better.

>     <param name="buffers" type="const GLuint *"/>
> 
> Same thing below.
> 
> 
>> +    </function>
>> +
>> +    <function name="BindBuffersRange" offset="assign">
>> +        <param name="target" type="GLenum"/>
>> +        <param name="first" type="GLuint"/>
>> +        <param name="count" type="GLsizei"/>
>> +        <param name="buffers" type="const GLuint *"/>
>> +        <param name="offsets" type="const GLintptr *"/>
>> +        <param name="sizes" type="const GLsizeiptr *"/>
>> +    </function>
>> +
>> +    <function name="BindTextures" offset="assign">
>> +        <param name="first" type="GLuint"/>
>> +        <param name="count" type="GLsizei"/>
>> +        <param name="textures" type="const GLuint*"/>
>> +    </function>
>> +
>> +    <function name="BindSamplers" offset="assign">
>> +        <param name="first" type="GLuint"/>
>> +        <param name="count" type="GLsizei"/>
>> +        <param name="samplers" type="const GLuint*"/>
>> +    </function>
>> +
>> +    <function name="BindImageTextures" offset="assign">
>> +        <param name="first" type="GLuint"/>
>> +        <param name="count" type="GLsizei"/>
>> +        <param name="textures" type="const GLuint*"/>
>> +    </function>
>> +
>> +    <function name="BindVertexBuffers" offset="assign">
>> +        <param name="first" type="GLuint"/>
>> +        <param name="count" type="GLsizei"/>
>> +        <param name="buffers" type="const GLuint*"/>
>> +        <param name="offsets" type="const GLintptr*"/>
>> +        <param name="strides" type="const GLsizei*"/>
>> +    </function>
>> +
> [...]
> 
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>