[Mesa-dev] [PATCH 02/16] radeonsi: Initial geometry shader support

Vadim Girlin vadimgirlin at gmail.com
Tue Jan 28 23:07:11 PST 2014


On Wed, 2014-01-29 at 07:13 +1000, Dave Airlie wrote:
> >> 3) In si_init_gs_rings:
> >> - could you please use readable decimal numbers for specifying the
> >> sizes? Like 1024 * 1024 * ...
> > [...]
> >> - isn't 64 MB too many for a ring buffer?
> >
> > I can write the numbers any way you like. :) But I just copied them from
> > the corresponding r600g patches; I don't know yet how these numbers were
> > derived, or what the constraints are for the ring buffer sizes. I'm
> > trying to find out more about this.
> >
> >
> I don't think they are derived from anything yet, they were just big
> numbers Vadim used,

IIRC all these magic numbers were taken from the fglrx command stream
for some simple GS test on my 512MB juniper card.

Vadim

> 
> I suppose we can calculate them from max vertices for the geom shader
> * number of outputs  * size of each output.
> 
> Dave.
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev





More information about the mesa-dev mailing list