[Mesa-dev] [PATCH] target-helpers: don't use designated initializers

Roland Scheidegger sroland at vmware.com
Tue Jul 1 16:38:57 PDT 2014


Am 01.07.2014 23:47, schrieb Emil Velikov:
> On 01/07/14 20:17, sroland at vmware.com wrote:
>> From: Roland Scheidegger <sroland at vmware.com>
>>
>> it looks since ce1a1372280d737a1b85279995529206586ae480 they are now included
>> in more places, in particular even for things buildable with msvc, and hence
>> those break the build.
> Microsoft were kind enough to finally add support for this C99 feature with
> VC12 (msvc 2013).
Yeah I know. Only 15 years late...

> Any idea if/when you'll have the chance to update ?
I think there were some things preventing this to happen soon though I
can't remember the details...

Roland


> 
> Reviewed-by: Emil Velikov <emil.l.velikov at gmail.com>
>> ---
>>  src/gallium/auxiliary/target-helpers/inline_drm_helper.h | 8 ++++----
>>  1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/src/gallium/auxiliary/target-helpers/inline_drm_helper.h b/src/gallium/auxiliary/target-helpers/inline_drm_helper.h
>> index a03db3a..3b36316 100644
>> --- a/src/gallium/auxiliary/target-helpers/inline_drm_helper.h
>> +++ b/src/gallium/auxiliary/target-helpers/inline_drm_helper.h
>> @@ -210,13 +210,13 @@ dd_driver_name(void)
>>  }
>>  
>>  static const struct drm_conf_ret throttle_ret = {
>> -   .type = DRM_CONF_INT,
>> -   .val.val_int = 2,
>> +   DRM_CONF_INT,
>> +   {2},
>>  };
>>  
>>  static const struct drm_conf_ret share_fd_ret = {
>> -   .type = DRM_CONF_BOOL,
>> -   .val.val_int = true,
>> +   DRM_CONF_BOOL,
>> +   {true},
>>  };
>>  
>>  static const struct drm_conf_ret *
>>


More information about the mesa-dev mailing list