[Mesa-dev] [PATCH v2] r600g: allow viewport index/layer to be sent to fs

[Tobias Droste]

Hi,

I did a piglit run with the gpu.py profile with and without the patch.
There were some switches from pass->fail and fail->pass in 
spec/glsl-1.50/execution/geometry/end-primitive but these seem to not be 
stable, because after a second with and without a patch different tests from 
this category pass/fail (in both cases with and without the patch).
I also ran these without "-fbo -auto" and there was no visible difference in 
the images but the test still failed. This was also discusses in IRC #dri-
devel.

Other than that I also ran the newly added piglit tests for 
ARB_fragment_layer_viewport-specific and they all pass or skip.

This was all done with a Evergreen/Juniper card.

Tobias

Am Di, 1. Juli 2014, 21:38:10 schrieb Ilia Mirkin:
> On Tue, Jul 1, 2014 at 9:23 PM, Michel Dänzer <michel at daenzer.net> wrote:
> > On 02.07.2014 01:25, Marek Olšák wrote:
> >> If the tests pass, the patch can be merged.
> > 
> > And if the patch causes no piglit regressions.
> 
> I can't vouch for that. I have a report that the
> ARB_fragment_layer_viewport-specific tests pass on a card covered by
> r600g (evergreen iirc). I've put that Tested-by tag in my commit
> description. Besides an ATI Rage128 sitting on my shelf, I have no
> ATI/AMD hardware to test with myself, and I don't want to go around
> soliciting people running piglit for me since (a) extracting glxinfos
> out of people is hard enough, getting someone to do a piglit run seems
> way harder, and (b) piglit runs can kill the system, most users aren't
> too happy about things like that.
> 
> TBH, I don't really care whether r600g gets this feature or not, but
> it would be nice if all the other drivers that have ARB_viewport_array
> could get it. Basically... do I need to add a CAP for this or not? I
> don't really care either way, but it would be really nice to get a
> definitive answer.
> 
> Cheers,
> 
>   -ilia
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev