[Mesa-dev] [PATCH v2 1/5] mesa/main: add ARB_clear_texture entrypoints

[Neil Roberts]

Ilia Mirkin <imirkin at alum.mit.edu> writes:

> I believe what this is saying is akin to "Danger! There is a hole from
> 145 to 146". Since ARB_clear_texture is 145, the hole is now just 146
> (ARB_enhanced_layouts)... Whereas your comments indicate the numbers
> of the actually-listed extensions.
>
> Note that I don't really understand what the point of extension
> numbers is in the first place, or why it's important to indicate where
> the holes are or what the extension numbers are. But I do think you're
> changing the intent of the comment here.

Ah yes, I think I misunderstood the intent of the comments. I will
change it to be like this:

> --- a/src/mapi/glapi/gen/gl_API.xml
> +++ b/src/mapi/glapi/gen/gl_API.xml
> @@ -8358,7 +8358,9 @@
>      </function>
>  </category>
>  
> -<!-- ARB extensions #145...#146 -->
> +<xi:include href="ARB_clear_texture.xml"
> xmlns:xi="http://www.w3.org/2001/XIn> clude"/>
> +
> +<!-- ARB extension #146 -->
>  
>  <xi:include href="ARB_multi_bind.xml" xmlns:xi="http://www.w3.org/2001/XInclude"/>

I only made the changes in the first place because your original patch
had started conflicting since the GL_ARB_multi_bind extension was added.
Sorry about messing it up.

Yes, I'm not sure what the point of those comments are. They are bit
messed up with extension number 128 as well so I think I'm not the only
one struggling with them.

Regards,
- Neil