[Mesa-dev] [Bug 80266] Many instances of 1<<31, which is undefined in C99

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Jul 3 22:42:33 PDT 2014


https://bugs.freedesktop.org/show_bug.cgi?id=80266

--- Comment #13 from Vittorio <zeccav at gmail.com> ---
More issues:
u_pack_color.h:365
"uc->ui = (a << 24) | (r << 16) | (g << 8) | b;"
should be
"uc->ui = ((unsigned int)a << 24) | (r << 16) | (g << 8) | b;"

m_matrix.c line 1156
"#define ONE(x)  (1<<(x+16))"
should be
"#define ONE(x)  (1U<<(x+16))"
because of ONE(15).
At line 1215
"if (m[15] == 1.0F) mask |= (1<<31);"
should be
"if (m[15] == 1.0F) mask |= (1U<<31);"

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140704/1a17d21c/attachment.html>


More information about the mesa-dev mailing list