[Mesa-dev] [PATCH 1/1] gallivm, llvmpipe: Handle MSAA textures in emit_fetch_texels in a preliminary fashion to prevent a crash in a Piglit test.

[Carl Worth]

Darius Goad <alegend45 at gmail.com> writes:
>  src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c | 2 ++
>  1 file changed, 2 insertions(+)

Hi Darius,

Welcome to the mesa development community! I hope you'll have a lot of
fun here.

I know that someone on IRC gave you some feedback on your commit
message, (that it should be formatted to 72 columns or so). Here's a
little more feedback.

The first line of the commit message should be a single-sentence summary
of *what* the patch does. There's an art to capturing all of that in
fewer than 80 characters, (though if you really struggle, that might be
a hint that the patch should be broken up into multiple patches).

After that, the commit should continue with one or more sentences,
(maybe even a few paragraphs), that describe the *how* and the *why* of
the patch.

I'm not familiar with the code you're modifying here, but let me give
you an example of how you might reformat your commit message according
to the above:

  gallivm, llvmpipe: Preliminary MSAA texture support in emit_fetch_texels

  This support is only preliminary because <of some explanation>. More
  complete support would involve <further explanation>.

  In the meantime, this commit does fix crashes in the following piglit
  tests:

	<list of affected tests>

  These crashes were occurring because of <additional explanation>.

Something along the lines of that, anyway. Hopefully that gives you the
right idea.

Some people hesitate to write that much, thinking, "How can a two line
patch justify 6 or more full sentences of explanation?". But in my
experience, no commit is short enough to not warrant both a sentence of
*what* and the essential sentence of *why*.

Those extra sentences of explanation are invaluable to people doing
review now, and priceless to people investigation the code history
later.

You can use "git commit --amend" or "git rebase -i origin/master" along
with a "reword" directive in the resulting command list to easily change
your commit message. And then you can email it again as a "v2" patch.

Thanks again for your contribution,

-Carl

-- 
carl.d.worth at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140705/2c7a9891/attachment.sig>