[Mesa-dev] [PATCH v3] gallivm, llvmpipe: Handle MSAA textures in emit_fetch_texels.

[Roland Scheidegger]

Am 05.07.2014 20:03, schrieb Darius Goad:
> This support is preliminary due to the fact that MSAA is not
> actually implemented. More complete support would most likely
> involve a rework of the Mesa architecture to support it.
> 
> However, this patch does fix the piglit test:
> spec/!OpenGL 3.2/glsl-resource-not-bound 2DMS
> 
> It also fixes Bug #79740.
> ---
>  src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c b/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c
> index 3d7df3e..4bf9242 100644
> --- a/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c
> +++ b/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c
> @@ -2329,9 +2329,11 @@ emit_fetch_texels( struct lp_build_tgsi_soa_context *bld,
>        dims = 1;
>        break;
>     case TGSI_TEXTURE_2D:
> +   case TGSI_TEXTURE_2D_MSAA:
>     case TGSI_TEXTURE_RECT:
>        dims = 2;
>        break;
> +   case TGSI_TEXTURE_2D_ARRAY_MSAA:
>     case TGSI_TEXTURE_2D_ARRAY:
>        layer_coord = 2;
>        dims = 2;
> 

Reviewed-by:
Roland Scheidegger <sroland at vmware.com>

Just a small nitpick, the comment isn't quite right. There's no "Mesa
architecture" work needed, just llvmpipe would need quite soem work to
support true msaa instead of the completely fake one it currently does.

Roland