[Mesa-dev] [PATCH 2/2] i965: Remove artificial dependency between math instructions.

Kenneth Graunke kenneth at whitecape.org
Mon Jul 7 16:21:12 PDT 2014


On Monday, July 07, 2014 01:39:17 PM Matt Turner wrote:
> ... on Gen7+. I'm not actually sure which class Gen6 fits into.

It looks like you actually did this for Gen6+, not Gen7+.  I think that's 
correct.  Gen6 is when we moved from the mathbox shared function to an actual 
MATH instruction.

Assuming you fix the commit message:
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

> ---
>  src/mesa/drivers/dri/i965/brw_schedule_instructions.cpp | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_schedule_instructions.cpp 
b/src/mesa/drivers/dri/i965/brw_schedule_instructions.cpp
> index 10a8f6d..04ac242 100644
> --- a/src/mesa/drivers/dri/i965/brw_schedule_instructions.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_schedule_instructions.cpp
> @@ -1356,6 +1356,7 @@ 
vec4_instruction_scheduler::issue_time(backend_instruction *inst)
>  void
>  instruction_scheduler::schedule_instructions(backend_instruction 
*next_block_header)
>  {
> +   struct brw_context *brw = bv->brw;
>     time = 0;
>  
>     /* Remove non-DAG heads from the list. */
> @@ -1424,7 +1425,7 @@ 
instruction_scheduler::schedule_instructions(backend_instruction 
*next_block_hea
>         * the next math instruction isn't going to make progress until the 
first
>         * is done.
>         */
> -      if (chosen->inst->is_math()) {
> +      if (brw->gen < 6 && chosen->inst->is_math()) {
>           foreach_in_list(schedule_node, n, &instructions) {
>  	    if (n->inst->is_math())
>  	       n->unblocked_time = MAX2(n->unblocked_time,
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140707/8f620a06/attachment.sig>


More information about the mesa-dev mailing list