[Mesa-dev] [PATCH 1/2] meta: Add a state flag for the GL_DITHER

[Pohjolainen, Topi]

On Mon, Jul 07, 2014 at 12:27:29PM +0100, Neil Roberts wrote:
> "Pohjolainen, Topi" <topi.pohjolainen at intel.com> writes:
> 
> > All the other state flags considered in _mesa_meta_begin() are
> > explicitly set as disabled. And having noticed that you
> > unconditionally disable dithering also in cleartexsubimage_using_fbo()
> > I'm wondering if I'm missing something.
> 
> My understanding is that _mesa_meta_begin is supposed to reset the state
> to the GL defaults and dithering is enabled by default in GL.
> 
> If I were to set it to disabled then it would also affect things like
> _mesa_meta_GenerateMipmap which uses MESA_META_ALL. Presumably that
> function will currently either use dithering or not depending on whether
> the user has toggled the state. I think it makes sense for that function
> to always use dithering so this patch arguably fixes a bug with that
> function (and others).

Thanks for the explanation, that makes perfect sense to me at least.

> 
> Thanks for the review.
> 
> Regards,
> - Neil