[Mesa-dev] [PATCH 1/5] configure.ac: require LLVM 3.4.2 for radeon

[Marek Olšák]

Yes, that sounds good. We should always support the latest stable
version of LLVM, but I don't think it's worth supporting anything
older than that.

It's also important to have the latest LLVM because it's sometimes the
only way to get the new features which are mentioned in the release
notes of Mesa. Older LLVM usually causes the driver not to advertise
all features despite what the release notes say.

Marek

On Thu, Jul 10, 2014 at 5:10 PM, Tom Stellard <tom at stellard.net> wrote:
> On Tue, Jul 08, 2014 at 03:37:02AM +0200, Marek Olšák wrote:
>> From: Marek Olšák <marek.olsak at amd.com>
>>
>> Needed by ARB_draw_indirect.
>
> I think we should come up with a rule for how long we should support
> older versions of LLVM.  Do you have any thoughts about this?  I was
> thinking we could have each Mesa release support current stable LLVM
> and also the development version from SVN.
>
> -Tom
>
>> ---
>>  configure.ac | 5 +++--
>>  1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/configure.ac b/configure.ac
>> index 4646212..9d5cd89 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -1888,8 +1888,9 @@ radeon_llvm_check() {
>>          AC_MSG_ERROR([--enable-gallium-llvm is required when building $1])
>>      fi
>>      LLVM_REQUIRED_VERSION_MAJOR="3"
>> -    LLVM_REQUIRED_VERSION_MINOR="3"
>> -    if test "$LLVM_VERSION_INT" -lt "${LLVM_REQUIRED_VERSION_MAJOR}0${LLVM_REQUIRED_VERSION_MINOR}"; then
>> +    LLVM_REQUIRED_VERSION_MINOR="4"
>> +    LLVM_REQUIRED_VERSION_PATCH="2"
>> +    if test "${LLVM_VERSION_INT}${LLVM_VERSION_PATCH}" -lt "${LLVM_REQUIRED_VERSION_MAJOR}0${LLVM_REQUIRED_VERSION_MINOR}${LLVM_REQUIRED_VERSION_PATCH}"; then
>>          AC_MSG_ERROR([LLVM $LLVM_REQUIRED_VERSION_MAJOR.$LLVM_REQUIRED_VERSION_MINOR or newer is required for $1])
>>      fi
>>      if test true && $LLVM_CONFIG --targets-built | grep -qvw 'R600' ; then
>> --
>> 1.9.1
>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/mesa-dev