[Mesa-dev] [PATCH V4 1/6] i965: Add message descriptor bit definitions for pixel interpolator

Kenneth Graunke kenneth at whitecape.org
Fri Jul 11 23:56:39 PDT 2014


On Saturday, July 12, 2014 03:20:10 PM Chris Forbes wrote:
> These got lost in the big brw_inst shakeup.
> 
> Signed-off-by: Chris Forbes <chrisf at ijw.co.nz>
> ---
>  src/mesa/drivers/dri/i965/brw_defines.h |  5 +++++
>  src/mesa/drivers/dri/i965/brw_inst.h    | 11 +++++++++++
>  2 files changed, 16 insertions(+)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_defines.h 
b/src/mesa/drivers/dri/i965/brw_defines.h
> index 0dadcb3..e528232 100644
> --- a/src/mesa/drivers/dri/i965/brw_defines.h
> +++ b/src/mesa/drivers/dri/i965/brw_defines.h
> @@ -1295,6 +1295,11 @@ enum brw_message_target {
>                                                                 (1 << 17))
>  #define GEN7_DATAPORT_SCRATCH_NUM_REGS_SHIFT                        12
>  
> +#define GEN7_PIXEL_INTERPOLATOR_LOC_SHARED_OFFSET     0
> +#define GEN7_PIXEL_INTERPOLATOR_LOC_SAMPLE            1
> +#define GEN7_PIXEL_INTERPOLATOR_LOC_CENTROID          2
> +#define GEN7_PIXEL_INTERPOLATOR_LOC_PER_SLOT_OFFSET   3
> +
>  /* HSW */
>  #define HSW_DATAPORT_DC_PORT0_OWORD_BLOCK_READ                      0
>  #define HSW_DATAPORT_DC_PORT0_UNALIGNED_OWORD_BLOCK_READ            1
> diff --git a/src/mesa/drivers/dri/i965/brw_inst.h 
b/src/mesa/drivers/dri/i965/brw_inst.h
> index ac00fd4..e880c9f 100644
> --- a/src/mesa/drivers/dri/i965/brw_inst.h
> +++ b/src/mesa/drivers/dri/i965/brw_inst.h
> @@ -527,6 +527,17 @@ F(ts_opcode,           MD( 0),  MD( 0))
>  /** @} */
>  
>  /**
> + * Pixel Interpolator message function control bits:
> + *  @{
> + */
> +F(pi_simd_mode,      MD(16),  MD(16))
> +F(pi_nopersp,        MD(14),  MD(14))
> +F(pi_message_type,   MD(13),  MD(12))
> +F(pi_slot_group,     MD(11),  MD(11))
> +F(pi_message_data,   MD(7),   MD(0))

Most other messages call this msg_control (so, pi_msg_control).  Any 
particular reason not to do that here?  I guess it's more payload data than 
message control bits, but...

Whatever you want to do is fine.

> +/** @} */
> +
> +/**
>   * Immediates:
>   *  @{
>   */
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140711/d732e311/attachment.sig>


More information about the mesa-dev mailing list