[Mesa-dev] [PATCH] glsl: Fix aggregates with dynamic initializers.

Kenneth Graunke kenneth at whitecape.org
Mon Jul 14 09:19:35 PDT 2014


On Thursday, July 10, 2014 09:55:31 AM Cody Northrop wrote:
> Vectors are falling in to the ir_dereference_array() path.
> 
> Without this change, the following glsl aborts the debug driver,
> or gets the wrong answer in release:
> 
> mat2x2 a = mat2( vec2( 1.0, vertex.x ), vec2( 0.0, 1.0 ) );
> 
> Also submitting piglit tests, will reference in bug.
> 
> v2: Rebase on Mesa master.
> 
> v3: Remove unneeded check for arrays, which are covered by
>     process_array_constructor(), recommended by Timothy Arceri.

Thanks for the feedback, Timothy, and for the updated patch, Cody.

Pushed.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140714/a6d17554/attachment.sig>


More information about the mesa-dev mailing list