[Mesa-dev] [PATCH 4/7] i965/vec4: Use foreach_inst_in_block a couple more places.

Matt Turner mattst88 at gmail.com
Thu Jul 17 15:26:04 PDT 2014


---
 src/mesa/drivers/dri/i965/brw_vec4.cpp     | 5 +----
 src/mesa/drivers/dri/i965/brw_vec4_cse.cpp | 5 +----
 2 files changed, 2 insertions(+), 8 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/brw_vec4.cpp b/src/mesa/drivers/dri/i965/brw_vec4.cpp
index 49a4e9b..045e1c5 100644
--- a/src/mesa/drivers/dri/i965/brw_vec4.cpp
+++ b/src/mesa/drivers/dri/i965/brw_vec4.cpp
@@ -755,14 +755,11 @@ vec4_visitor::opt_set_dependency_control()
 
    for (int i = 0; i < cfg->num_blocks; i++) {
       bblock_t *bblock = cfg->blocks[i];
-      vec4_instruction *inst;
 
       memset(last_grf_write, 0, sizeof(last_grf_write));
       memset(last_mrf_write, 0, sizeof(last_mrf_write));
 
-      for (inst = (vec4_instruction *)bblock->start;
-           inst != (vec4_instruction *)bblock->end->next;
-           inst = (vec4_instruction *)inst->next) {
+      foreach_inst_in_block (vec4_instruction, inst, bblock) {
          /* If we read from a register that we were doing dependency control
           * on, don't do dependency control across the read.
           */
diff --git a/src/mesa/drivers/dri/i965/brw_vec4_cse.cpp b/src/mesa/drivers/dri/i965/brw_vec4_cse.cpp
index 86360d2..29d2e02 100644
--- a/src/mesa/drivers/dri/i965/brw_vec4_cse.cpp
+++ b/src/mesa/drivers/dri/i965/brw_vec4_cse.cpp
@@ -132,10 +132,7 @@ vec4_visitor::opt_cse_local(bblock_t *block)
    void *cse_ctx = ralloc_context(NULL);
 
    int ip = block->start_ip;
-   for (vec4_instruction *inst = (vec4_instruction *)block->start;
-        inst != block->end->next;
-        inst = (vec4_instruction *) inst->next) {
-
+   foreach_inst_in_block (vec4_instruction, inst, block) {
       /* Skip some cases. */
       if (is_expression(inst) && !inst->predicate && inst->mlen == 0 &&
           (inst->dst.file != HW_REG || inst->dst.is_null()))
-- 
1.8.5.5



More information about the mesa-dev mailing list