[Mesa-dev] [PATCH 10/12] main/format_pack: Fix a wrong datatype in pack_ubyte_R8G8_UNORM

[Brian Paul]

On 07/17/2014 12:04 PM, Jason Ekstrand wrote:
> Before it was only storing one of the color components due to truncation.
> With this patch it now properly stores all of them.
>
> Signed-off-by: Jason Ekstrand <jason.ekstrand at intel.com>
> ---
>   src/mesa/main/format_pack.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mesa/main/format_pack.c b/src/mesa/main/format_pack.c
> index fb3feb5..4b52405 100644
> --- a/src/mesa/main/format_pack.c
> +++ b/src/mesa/main/format_pack.c
> @@ -856,7 +856,7 @@ pack_float_R_UNORM8(const GLfloat src[4], void *dst)
>   static void
>   pack_ubyte_R8G8_UNORM(const GLubyte src[4], void *dst)
>   {
> -   GLubyte *d = ((GLubyte *) dst);
> +   GLushort *d = ((GLushort *) dst);
>      *d = PACK_COLOR_88(src[GCOMP], src[RCOMP]);
>   }
>
>

Reviewed-by: Brian Paul <brianp at vmware.com>

Should probably be tagged for the stable branch too.