[Mesa-dev] [PATCH 00/16] Many UBO fixes

[Matt Turner]

On Mon, Jul 21, 2014 at 2:04 PM, Ian Romanick <idr at freedesktop.org> wrote:
> Around the time OpenGL ES 3.1 was released, Khronos made some
> significant updates to the OpenGL ES 3.0 conformance suite.  These
> updates uncovered a number of bugs in our implementation of UBOs.
>
> This patch series fixes all 147 failing tests that I could attribute to
> UBO related problems.
>
> With the exception of patches 1 and 2, I would like to see all of these
> land on the 10.2 branch, but, due to the scope of changes, they should
> probably get some soak time on master first.

The series looks good to me. I sent some small comments, and I'm kind
of confused about patch 3, but the rest are

Reviewed-by: Matt Turner <mattst88 at gmail.com>

and 3 is too if I can figure out what ensures array_index is a constant.