[Mesa-dev] [PATCH 06/26] glsl: Use bit-flags image attributes and uint16_t for the image format

[Kenneth Graunke]

On Monday, July 14, 2014 03:48:38 PM Ian Romanick wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
> 
> All of the GL image enums fit in 16-bits.
> 
> Also move the fields from the anonymous "image" structucture to the next
> higher structure.  This will enable packing the bits with the other
> bitfield.
> 
> Valgrind massif results for a trimmed apitrace of dota2:
> 
>                   n        time(i)         total(B)   useful-heap(B) extra-heap(B)    stacks(B)
> Before (32-bit): 76 40,572,916,873       68,831,248       63,328,783     5,502,465            0
> After  (32-bit): 70 40,577,421,777       68,487,584       62,973,695     5,513,889            0
> 
> Before (64-bit): 60 36,822,640,058       96,526,824       88,735,296     7,791,528            0
> After  (64-bit): 74 37,124,603,758       95,891,808       88,466,712     7,425,096            0
> 
> A real savings of 346KiB on 32-bit and 262KiB on 64-bit.
> 
> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>

This patch is:
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140721/d77ef5d5/attachment-0001.sig>