[Mesa-dev] [PATCH 10/17] i965/gen6 fbo: make unmatched depth/stencil configs return unsupported

Pohjolainen, Topi topi.pohjolainen at intel.com
Tue Jul 22 02:55:47 PDT 2014


On Fri, Jul 18, 2014 at 02:16:45PM -0700, Jordan Justen wrote:
> (f3c886b for gen6)
> 
> Signed-off-by: Jordan Justen <jordan.l.justen at intel.com>
> ---
>  src/mesa/drivers/dri/i965/intel_fbo.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/intel_fbo.c b/src/mesa/drivers/dri/i965/intel_fbo.c
> index e43e18b..22f707f 100644
> --- a/src/mesa/drivers/dri/i965/intel_fbo.c
> +++ b/src/mesa/drivers/dri/i965/intel_fbo.c
> @@ -673,8 +673,8 @@ intel_validate_framebuffer(struct gl_context *ctx, struct gl_framebuffer *fb)
>     }
>  
>     if (depth_mt && stencil_mt) {
> -      if (brw->gen >= 7) {
> -         /* For gen >= 7, we are using the lod/minimum-array-element fields
> +      if (brw->gen >= 6) {
> +         /* For gen >= 6, we are using the lod/minimum-array-element fields
>            * and supportting layered rendering. This means that we must restrict

You could also fix the typo (supportting) while at it:

Reviewed-by: Topi Pohjolainen <topi.pohjolainen at intel.com>

>            * the depth & stencil attachments to match in various more retrictive
>            * ways. (width, height, depth, LOD and layer)
> -- 
> 2.0.1
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list