[Mesa-dev] [PATCH 6/6] gallium: remove PIPE_CAP_BUFFER_SHARE cap and get_param sw_winsys hook

Emil Velikov emil.l.velikov at gmail.com
Wed Jul 30 08:50:01 PDT 2014


On 30/07/14 08:14, Giovanni Campagna wrote:
> On Jul 29, 2014 7:42 PM, "Emil Velikov" <emil.l.velikov at gmail.com> wrote:
>>
>> On 24/07/14 01:43, Emil Velikov wrote:
>>> The kms_swrast driver has a separate InitScreen hook for its DriverAPI
>>> from the rest of the DRI2 drivers, all of which capable of buffer
>>> sharing. As such we no longer need to dive through the pipe-driver and
>>> winsys layers in order to determine if the driver can share buffers or
>>> not and we can explicitly set screen->can_share_buffer in InitScreen.
>>>
>>> XXX: Squash with the original commit ?
>>>
>> Hi Giovanni,
>>
>> With the current implementation of kms_dri + megadrivers the PIPE_CAP is
> no
>> longer required. Are you OK if we drop it ?
> 
> Yes, it's an implementation detail and I don't particularly care about it,
> as long as we have a way not to expose the image egl extensions.
> I did not answer immediately because I wanted to test this again and did
> not find time yet, but this is now in use for gnome-continuous through the
> egl-drm branch and it works, so it's good to go, I believe.
> 
Thanks. Pushed to master :)

-Emil

> Giovanni
> 
>> -Emil
>>



More information about the mesa-dev mailing list