[Mesa-dev] [PATCH 3/3] ra: optimistically color only one node at a time

Eric Anholt eric at anholt.net
Wed Jul 30 16:35:36 PDT 2014

Connor Abbott <cwabbott0 at gmail.com> writes:

> Before, when we encountered a situation where we had to optimistically
> color a node, we would immediately give up and push all the remaining
> nodes on the stack in the order of their index - which is a random, and
> potentially not optimal, order. Instead, choose one node to
> optimistically color in ra_select(), and then once we've optimistically
> colored it, keep on going as normal in the hopes that we've opened up
> more avenues for the normal select phase to make progress. In cases with
> high register pressure, this helps make the order we push things on the
> stack much better, and therefore increase the chance that we can allocate
> successfully.
> Also, consider all the spillable registers as canidates for spilling,
> including the ones that were successfully given a color. The old
> behavior was incompatible with the new way of doing optimistic coloring,
> so while we're modifying this code let's make it do something more
> sensible as well.

That seems like that should be a separate commit before this one.

Other than trailing whitespace, patches 1 and 2 are:

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140730/cc7a7fa8/attachment.sig>

More information about the mesa-dev mailing list