[Mesa-dev] [PATCH 0/2] Build a driswrast-using libGL on non-DRM targets

[Emil Velikov]

On 04/06/14 13:36, Jon TURNEY wrote:
> On 03/06/2014 17:37, Emil Velikov wrote:
>> On 03/06/14 14:14, Jon TURNEY wrote:
>>> As a follow-up to my "Fix Apple-DRI GLX" patchset, allow building of a libGL
>>> capable of using driswrast on targets without libdrm, and make that the
>>> default
>>> configuration.
>>>
>>> The --disable-driglx-direct option only appears to exist for the benefit of
>>> such
>>> targets, so it could probably be removed in future.
>>>
>> IIRC people that build non-dri glx(libGL) i.e. --enable-xlib-glx normally set
>> --disable-driglx-direct as well. Not sure if they will be affected by your
>> patches though. I will take a closer look over the weekend, unless you beat me
>> to it.
> 
> Good point.
> 
> Looking at configure.ac, it doesn't look like --disable-driglx-direct has any
> meaning when --enable-xlib-glx is used.
> 
> It seems that --enable-xlib-glx requires --disable-dri currently, and it seems
> to build fine with these patches applied.
> 
> My comment that --disable-driglx-direct only exists for the benefit of non-DRM
> targets was based on [1] et seq.
> 
Wasn't aware of the "story" behind disable-driglx-direct, and the commit
message brings a lot. Thanks.

Did a bit of time tracing all the GLX_{IN,}DIRECT_RENDERING uses and I'm
starting to regret it.
IMHO patches look good and build fine in here, which is always a plus :)

Reviewed-by: Emil Velikov <emil.l.velikov at gmail.com>

-Emil
> [1]
> http://cgit.freedesktop.org/mesa/mesa/commit/?id=758561786c3a34303e6c85dfdb996b94a4eed678
>