[Mesa-dev] [PATCH 02/15] glsl: Do not allow undefining the built-in macros
cworth at cworth.org
Wed Jun 11 19:23:54 PDT 2014
Anuj Phogat <anuj.phogat at gmail.com> writes:
> Following changes in above code will also fix the GL_ES macro case:
> - || strcmp("__VERSION__", $3) == 0)
> + || strcmp("__VERSION__", $3) == 0
> + || (parser->is_gles && strcmp("GL_ES", $3) == 0))
> Do you want me to send out an updated patch with changes suggested
> by me in above comment or I can just push it with your r-b?
You can push out the above code with my Reviewed-by. I don't think we've
got the sophistication in glccp/tests to do version-specific testing, so
I'll let this piece slide through without the additional testing there,
(and just trust piglit to catch this piece).
> Thanks Carl. I'll take care of it in future.
carl.d.worth at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 818 bytes
Desc: not available
More information about the mesa-dev