[Mesa-dev] [PATCH 02/15] glsl: Do not allow undefining the built-in macros

Carl Worth cworth at cworth.org
Mon Jun 23 15:48:18 PDT 2014

Anuj Phogat <anuj.phogat at gmail.com> writes:
> Fixes piglit tests in spec/glsl-es-3.00/compile:
> Cc: <mesa-stable at lists.freedesktop.org>

For this change, (and other similar changes in the series, as well as
subsequent pre-processor changes that I am writing), I'm deciding to
generally not pick these over to the stable branch.

For one, my series is getting fairly long (21 patches and counting) and
would add quite a lot of clutter to the stable branch.

More importantly, though, these changes all improve conformance (as
measured by a very picky test suite), most of them don't actually fix
bugs. That is, they don't make mesa start accepting valid GLSL programs
that were previously being rejected.

Instead, some make mesa more correct to generate errors in case an
application does something pointless and bizarre, like:

	#undef __LINE__

Some of the patches do make mesa start accepting valid programs, but
they are in cases where the program would have to do something bizarre
and pointless such as:

	#  /* Hah-ha! */ define FOO bar

I just don't see anything like that coming up in the wild, (outside of
stress-testing in test suites).

So, these are all good improvements to mesa, but not important for the
stable branch.


carl.d.worth at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140623/f104b713/attachment-0001.sig>

More information about the mesa-dev mailing list