[Mesa-dev] [PATCH] ax_prog_flex.m4: change grep syntax to accept e.g. flex.real

[Andreas Oberritter]

Hello Jonathan,

On 10.03.2014 16:04, Jonathan Gray wrote:
> On Thu, Jul 18, 2013 at 01:59:37PM -0700, Matt Turner wrote:
>> On Mon, Apr 15, 2013 at 1:46 PM, Andreas Oberritter <obi at saftware.de> wrote:
>>> This is required in case a wrapper or symlink is used. This patch
>>> has also been sent upstream, awaiting moderation.
>>>
>>> Signed-off-by: Andreas Oberritter <obi at saftware.de>
>>> ---
>>
>> Thanks, committed (finally).
> 
> Trying to catch up with recent versions of mesa and noticed that
> this introduced the use of the gnu specific empty string
> escape sequences that were removed from configure.ac for
> the llvm-config tests in favour of using -w.
> 
> How about something like the following which makes the test
> work as intended on OpenBSD?
> 
> diff --git m4/ax_prog_flex.m4 m4/ax_prog_flex.m4
> index 82fbc30..f83f42c 100644
> --- m4/ax_prog_flex.m4
> +++ m4/ax_prog_flex.m4
> @@ -53,7 +53,7 @@ AC_DEFUN([AX_PROG_FLEX], [
>    AC_REQUIRE([AC_PROG_EGREP])
>  
>    AC_CACHE_CHECK([if flex is the lexer generator],[ax_cv_prog_flex],[
> -    AS_IF([$LEX --version 2>/dev/null | $EGREP -q '^\<flex\>'],
> +    AS_IF([$LEX --version 2>/dev/null | $EGREP -qw '^flex'],
>        [ax_cv_prog_flex=yes], [ax_cv_prog_flex=no])
>    ])
>    AS_IF([test "$ax_cv_prog_flex" = "yes"],
> 

this change looks good to me. Note that my patch was also applied in
commit 852c172e43628d23e571d49eeae4e78bc0623ae3 of autoconf-archive.git.
Would you mind submitting your change to
autoconf-archive-maintainers at gnu.org, too?

Regards,
Andreas