[Mesa-dev] [PATCH 1/7] i965/fs: Delete dead code to fail compiles with SIMD16 pull parameters.

Kenneth Graunke kenneth at whitecape.org
Tue Mar 11 23:48:50 PDT 2014


The SIMD8 compile will determine whether pull parameters are necessary.
If so, it will set prog_data->nr_pull_params to a value greater than 0.

brw_wm_fs_emit checks if nr_pull_params > 0 and skips the SIMD16 compile
altogether.  So, this code should never occur.

Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
---
 src/mesa/drivers/dri/i965/brw_fs.cpp | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp
index 0945343..c24d2f8 100644
--- a/src/mesa/drivers/dri/i965/brw_fs.cpp
+++ b/src/mesa/drivers/dri/i965/brw_fs.cpp
@@ -1904,11 +1904,6 @@ fs_visitor::setup_pull_constants()
    if (uniforms <= max_uniform_components)
       return;
 
-   if (dispatch_width == 16) {
-      fail("Pull constants not supported in SIMD16\n");
-      return;
-   }
-
    /* Just demote the end of the list.  We could probably do better
     * here, demoting things that are rarely used in the program first.
     */
-- 
1.9.0



More information about the mesa-dev mailing list