[Mesa-dev] [PATCH] linker: Fix consumer_inputs_with_locations indexing

Kenneth Graunke kenneth at whitecape.org
Mon May 5 14:44:17 PDT 2014

On 05/05/2014 10:56 AM, Ian Romanick wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
> In an earlier incarnation of populate_consumer_input_sets and
> get_matching_input, the consumer_inputs_with_locations array was indexed
> using the user-specified location.  In that version, only user-defined
> varyings were included in the array.
> In the current incarnation, the Mesa location is used to index the
> array, and built-in varyings are included.
> This change fixes the unit test to exepect gl_ClipDistance in the array,
> and it resizes the arrays to actually be big enough.  It's just dumb
> luck that the existing piglit tests use small enough locations to not
> stomp the stack. :(
> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=78258
> Cc: "10.2" <mesa-stable at lists.freedesktop.org>
> Cc: Vinson Lee <vlee at freedesktop.org>
> ---
>  src/glsl/link_varyings.cpp       |  8 ++++----
>  src/glsl/tests/varyings_test.cpp | 11 +++++------
>  2 files changed, 9 insertions(+), 10 deletions(-)

Looks reasonable to me.  Presumably this is new code, so we don't need
to backport beyond 10.2.

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140505/8fd9109d/attachment.sig>

More information about the mesa-dev mailing list