[Mesa-dev] [Bug 78318] [swrast] piglit glsl-kwin-blur-1 regression

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed May 28 13:23:45 PDT 2014


https://bugs.freedesktop.org/show_bug.cgi?id=78318

--- Comment #1 from Kenneth Graunke <kenneth at whitecape.org> ---
This is the first broken commit:

commit ca21cffebd063354291d561eadc2ded8795a5333
Author: Ian Romanick <ian.d.romanick at intel.com>
Date:   Tue Mar 25 18:34:31 2014 -0700

    meta: Fix saving the program pipeline state

    This code was broken in some odd ways before.  Too much state was being
    saved, it was being restored in the wrong order, and in the wrong way.
    The biggest problem was that the pipeline object was restored before
    restoring the programs attached to the default pipeline.

    Fixes a regression in the glean texgen test.

    v3: Fairly significant re-write.  I think it's much cleaner now, and it
    avoids a bug with some meta ops that use shaders (reported by Chia-I).

    v4: Check Pipeline.Current against NULL instead of Pipeline.Default.
    Suggested by Chia-I.

    Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
    Reviewed-by: Chia-I Wu <olv at lunarg.com>

The test passes with the previous commit.  With this commit, Mesa fails to
build due to a missing } in meta.c, but with that fixed, the test fails.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140528/5d5817d2/attachment.html>


More information about the mesa-dev mailing list