[Mesa-dev] [PATCH 03/21] glsl: Eliminate ir_variable::data.atomic.buffer_index

[Kenneth Graunke]

On Tuesday, May 27, 2014 07:48:58 PM Ian Romanick wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
> 
> Just use ir_variable::data.binding... because that's the where the
> binding is stored for everything else that can use layout(binding=).
> 
> No change in the peak ir_variable memory usage in a trimmed apitrace of
> dota2 on 64-bit.
> 
> Reduces the peak ir_variable memory usage in a trimmed apitrace of dota2
> by 102KiB on 32-bit.
> 
> Before: IR MEM: variable usage / name / total: 4955496 915817 5871313
> After:  IR MEM: variable usage / name / total: 4850844 915817 5766661
> 
> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>

This patch seems good to me - it puts the value of the binding layout 
qualifier in the same place for everything that uses it.

Patches 3-4 are:
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140530/8359a22c/attachment-0001.sig>